Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracing/GRPC: Set TLS credentials only when insecure is false. #10592

Merged
merged 1 commit into from Apr 14, 2022
Merged

Tracing/GRPC: Set TLS credentials only when insecure is false. #10592

merged 1 commit into from Apr 14, 2022

Conversation

roidelapluie
Copy link
Member

Fixes #10542

Signed-off-by: Julien Pivotto roidelapluie@o11y.eu

@roidelapluie
Tracing/GRPC: Set TLS credentials only when insecure is false.
9327daa 
Fixes prometheus#10542

Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
@roidelapluie roidelapluie mentioned this pull request Apr 14, 2022
Closed
@Nexucis
Copy link
Member

Nexucis commented Apr 14, 2022

from my point of view, it makes more sense that is done like that.
Any reason it wasn't done like that before ? (just to have some context / background)

@roidelapluie
Copy link
Member Author

from my point of view, it makes more sense that is done like that.
Any reason it wasn't done like that before ? (just to have some context / background)

Yes:

  • Every indirection to an if is a win to me
  • If you are redirected from an insecure to a secure endpoint this could have been helpful (not sure redirections exist for grpc)

@roidelapluie roidelapluie merged commit b4d0dcb into prometheus:release-2.35 Apr 14, 2022
@QuentinBisson QuentinBisson mentioned this pull request Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nexucis Nexucis Nexucis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roidelapluie @Nexucis